Bug 140810 - Rewrite the fast/css/css2-system-fonts.html test to be more useful on all platforms
Summary: Rewrite the fast/css/css2-system-fonts.html test to be more useful on all pla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://src.chromium.org/viewvc/blink?...
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 140577
  Show dependency tree / graph
 
Reported: 2015-01-22 18:44 PST by Chris Dumez
Modified: 2015-01-23 00:25 PST (History)
5 users (show)

See Also:

Attachments
WIP patch (10.03 KB, patch)
2015-01-22 18:55 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (218.64 KB, patch)
2015-01-22 18:58 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (230.98 KB, patch)
2015-01-22 19:13 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (575.13 KB, application/zip)
2015-01-22 19:29 PST, Build Bot 		no flags Details
Patch (232.78 KB, patch)
2015-01-22 19:38 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-22 18:44:09 PST 
Make the fast/css/css2-system-fonts.html explicit about the font styles expected on each platform instead of just Mac.
It also converts the test to be text only as the style information is now displayed in text format.

This change is in preparation for a refactor of system font handling.
Comment 1 Chris Dumez 2015-01-22 18:55:01 PST 
Created attachment 245191 [details]
WIP patch
Comment 2 Chris Dumez 2015-01-22 18:58:47 PST 
Created attachment 245192 [details]
Patch
Comment 3 Chris Dumez 2015-01-22 19:13:59 PST 
Created attachment 245193 [details]
Patch
Comment 4 Build Bot 2015-01-22 19:29:24 PST 
Comment on attachment 245193 [details]
Patch

Attachment 245193 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6295235260841984

New failing tests:
fast/css/css2-system-fonts.html
Comment 5 Build Bot 2015-01-22 19:29:27 PST 
Created attachment 245195 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Chris Dumez 2015-01-22 19:38:37 PST 
Created attachment 245196 [details]
Patch
Comment 7 WebKit Commit Bot 2015-01-23 00:25:20 PST 
Comment on attachment 245196 [details]
Patch

Clearing flags on attachment: 245196

Committed r178987: <http://trac.webkit.org/changeset/178987>
Comment 8 WebKit Commit Bot 2015-01-23 00:25:25 PST 
All reviewed patches have been landed.  Closing bug.