Bug 140752 - BytecodeGenerator shouldn't expose all of its member variables
Summary: BytecodeGenerator shouldn't expose all of its member variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 140491
  Show dependency tree / graph
 
Reported: 2015-01-21 17:49 PST by Ryosuke Niwa
Modified: 2015-01-21 18:06 PST (History)
5 users (show)

See Also:

Attachments
Fixes the bug (4.00 KB, patch)
2015-01-21 17:52 PST, Ryosuke Niwa 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-01-21 17:49:37 PST 
Right now, all m_* members of BytecodeGenerator are public. We should make them private.
Comment 1 Ryosuke Niwa 2015-01-21 17:52:51 PST 
Created attachment 245103 [details]
Fixes the bug
Comment 2 Mark Lam 2015-01-21 17:55:07 PST 
Comment on attachment 245103 [details]
Fixes the bug

r=me
Comment 3 Ryosuke Niwa 2015-01-21 18:06:27 PST 
Committed r178882: <http://trac.webkit.org/changeset/178882>