Bug 140749 - Drop the legacy FeatureCounter class
Summary: Drop the legacy FeatureCounter class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 140463
  Show dependency treegraph
 
Reported: 2015-01-21 16:25 PST by Chris Dumez
Modified: 2015-01-22 14:19 PST (History)
7 users (show)

See Also:


Attachments
Patch (64.18 KB, patch)
2015-01-21 16:43 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (65.94 KB, patch)
2015-01-21 17:06 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (528.02 KB, application/zip)
2015-01-21 17:57 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (655.12 KB, application/zip)
2015-01-21 18:04 PST, Build Bot
no flags Details
Patch (66.00 KB, patch)
2015-01-21 20:14 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-21 16:25:13 PST
Drop the legacy FeatureCounter class and use DiagnosticLoggingClient instead.
Comment 1 Chris Dumez 2015-01-21 16:43:24 PST
Created attachment 245099 [details]
Patch
Comment 2 Chris Dumez 2015-01-21 17:06:34 PST
Created attachment 245100 [details]
Patch
Comment 3 Build Bot 2015-01-21 17:57:25 PST
Comment on attachment 245100 [details]
Patch

Attachment 245100 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6281574714703872

New failing tests:
media/track/track-remove-crash.html
Comment 4 Build Bot 2015-01-21 17:57:28 PST
Created attachment 245104 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-01-21 18:04:30 PST
Comment on attachment 245100 [details]
Patch

Attachment 245100 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6567277952499712

New failing tests:
media/track/track-remove-crash.html
Comment 6 Build Bot 2015-01-21 18:04:36 PST
Created attachment 245105 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Chris Dumez 2015-01-21 20:14:21 PST
Created attachment 245110 [details]
Patch
Comment 8 Andreas Kling 2015-01-22 13:35:55 PST
Comment on attachment 245110 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2015-01-22 14:19:43 PST
Comment on attachment 245110 [details]
Patch

Clearing flags on attachment: 245110

Committed r178949: <http://trac.webkit.org/changeset/178949>
Comment 10 WebKit Commit Bot 2015-01-22 14:19:49 PST
All reviewed patches have been landed.  Closing bug.