Bug 140670 - Fix cast-align warning in Source/WebCore/platform/efl/EflScreenUtilities.cpp
Summary: Fix cast-align warning in Source/WebCore/platform/efl/EflScreenUtilities.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency treegraph
 
Reported: 2015-01-20 03:45 PST by Csaba Osztrogonác
Modified: 2015-05-18 02:43 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2015-01-20 03:46 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-01-20 03:45:45 PST
../../Source/WebCore/platform/efl/EflScreenUtilities.cpp:134:39: warning: cast from 'unsigned char *' to 'int *' increases required alignment from 1 to 4 [-Wc
ast-align]
    return ecore_x_cursor_new(window, (int*)(buffer), cursorSize.width(), cursorSize.height(), hotSpot.x(), hotSpot.y());
                                      ^~~~~~~~~~~~~~
1 warning generated.
----

The buffer is the return value of cairo_image_surface_get_data() which is guaranteed to be 4 byte aligned, it's safe to cast to int* .
Comment 1 Csaba Osztrogonác 2015-01-20 03:46:31 PST
Created attachment 244981 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-21 00:46:40 PST
Comment on attachment 244981 [details]
Patch

Clearing flags on attachment: 244981

Committed r178821: <http://trac.webkit.org/changeset/178821>
Comment 3 WebKit Commit Bot 2015-01-21 00:46:43 PST
All reviewed patches have been landed.  Closing bug.