Bug 140643 - REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is offset by flipped-ness
Summary: REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-19 15:17 PST by Beth Dakin
Modified: 2015-01-20 10:40 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2015-01-19 15:19 PST, Beth Dakin
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-01-19 15:17:13 PST
REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is offset by flipped-ness

rdar://problem/19489593
Comment 1 Beth Dakin 2015-01-19 15:19:56 PST
Created attachment 244930 [details]
Patch
Comment 2 Tim Horton 2015-01-19 15:22:20 PST
Comment on attachment 244930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244930&action=review

> Source/WebKit/mac/WebView/WebView.mm:8575
> +    if ([self isFlipped])

dot notation!
Comment 3 Beth Dakin 2015-01-19 15:24:59 PST
http://trac.webkit.org/changeset/178676

Thank you!
Comment 4 Darin Adler 2015-01-19 20:23:08 PST
Wow, I had no idea we supported having the WebView be flipped!
Comment 5 Beth Dakin 2015-01-20 10:40:48 PST
(In reply to comment #4)
> Wow, I had no idea we supported having the WebView be flipped!

It was a surprise to everyone I've talked to so far!