WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140643
REGRESSION (
r178290
): Yellow highlight from context menu Lookup in Dictionary is offset by flipped-ness
https://bugs.webkit.org/show_bug.cgi?id=140643
Summary
REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary...
Beth Dakin
Reported
2015-01-19 15:17:13 PST
REGRESSION (
r178290
): Yellow highlight from context menu Lookup in Dictionary is offset by flipped-ness
rdar://problem/19489593
Attachments
Patch
(1.48 KB, patch)
2015-01-19 15:19 PST
,
Beth Dakin
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2015-01-19 15:19:56 PST
Created
attachment 244930
[details]
Patch
Tim Horton
Comment 2
2015-01-19 15:22:20 PST
Comment on
attachment 244930
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=244930&action=review
> Source/WebKit/mac/WebView/WebView.mm:8575 > + if ([self isFlipped])
dot notation!
Beth Dakin
Comment 3
2015-01-19 15:24:59 PST
http://trac.webkit.org/changeset/178676
Thank you!
Darin Adler
Comment 4
2015-01-19 20:23:08 PST
Wow, I had no idea we supported having the WebView be flipped!
Beth Dakin
Comment 5
2015-01-20 10:40:48 PST
(In reply to
comment #4
)
> Wow, I had no idea we supported having the WebView be flipped!
It was a surprise to everyone I've talked to so far!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug