Compiling GTK port with -DENABLE_JIT=OFF -DENABLE_LLINT_C_LOOP=ON and with -DENABLE_YARR_JIT=0 ends with: /builddir/build/BUILD/webkitgtk-2.7.3/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp: In member function 'WTF::Vector<std::pair<int, int> > JSC::BasicBlockLocation::getExecutedRanges() const': /builddir/build/BUILD/webkitgtk-2.7.3/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:54:20: error: 'INT_MAX' was not declared in this scope Gap minGap(INT_MAX, 0); ^ /builddir/build/BUILD/webkitgtk-2.7.3/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp: In member function 'void JSC::BasicBlockLocation::dumpData() const': /builddir/build/BUILD/webkitgtk-2.7.3/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:76:117: error: 'dataLogF' was not declared in this scope dataLogF("\tBasicBlock: [%d, %d] hasExecuted: %s\n", gap.first, gap.second, hasExecuted() ? "true" : "false"); It also applies for trunk.
Created attachment 244896 [details] Patch
Attachment 244896 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 244897 [details] Patch
lgtm, thanks
Comment on attachment 244897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244897&action=review > Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:34 > #include "CCallHelpers.h" > > +#include <climits> > + > +#include <wtf/DataLog.h> LGTM, but please remove the blank lines before landing.
Comment on attachment 244897 [details] Patch #include "config.h" #include "BasicBlockLocation.h" #include "CCallHelpers.h" #include <climits> #include <wtf/DataLog.h>
Committed r178708: <http://trac.webkit.org/changeset/178708>
*** Bug 142511 has been marked as a duplicate of this bug. ***
*** Bug 139588 has been marked as a duplicate of this bug. ***