Bug 140584 – Add initial experimental user content filtering API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Add initial experimental user content filtering API

[Sam Weinig]

Created attachment 244844 [details]
Patch

[Sam Weinig]

The one big thing I think this API is missing, and that will need to be addressed, is dealing with a compilation phase of the rule list. This is largely due to the fact that I am not sure what we want our model to be. Should all loads be deferred when we are compiling the rule list? Should the client of the API have to explicitly ask for the rule list to be compiled and then pass the compiled list to WKUserContentController?

[Sam Weinig]

Created attachment 244852 [details]
Patch

[Benjamin Poulain]

Comment on attachment 244852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244852&action=review

Thanks a lot for building the APIs!

General comments:
-IMHO, rulelist is a poor name for the JSON string.
-You really like making interfaces :)

> Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:35
> +- (void)_removeAllUserContentFilters;

I am curious why you added remove-all but not remove-one.

> Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentFilter.h:31
> +@interface _WKUserContentFilter : NSObject

I am not a fan of the name ContentFilter. Hopefully we will do more than filtering content :)

> Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentFilter.h:33
> +- (instancetype)_initWithName:(NSString *)name ruleList:(NSString *)ruleList;

Isn't it a little weird to call the argument ruleList since it is a string?

[Sam Weinig]

(In reply to comment #4)
> Comment on attachment 244852 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244852&action=review
> 
> Thanks a lot for building the APIs!
> 
> General comments:
> -IMHO, rulelist is a poor name for the JSON string.

I'll use serializedRules as you did.

> -You really like making interfaces :)

:)

> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:35
> > +- (void)_removeAllUserContentFilters;
> 
> I am curious why you added remove-all but not remove-one.

Just to match UserScripts, and no other good reason.

> 
> > Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentFilter.h:31
> > +@interface _WKUserContentFilter : NSObject
> 
> I am not a fan of the name ContentFilter. Hopefully we will do more than
> filtering content :)

Fair enough.  I thought ContentExtension was too broad :). We will have to find something in the middle.

> 
> > Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentFilter.h:33
> > +- (instancetype)_initWithName:(NSString *)name ruleList:(NSString *)ruleList;
> 
> Isn't it a little weird to call the argument ruleList since it is a string?

I'll change it.

[Sam Weinig]

Committed r178634: <http://trac.webkit.org/changeset/178634>