Bug 140556 – Generate shorthandForProperty() implementation from CSSPropertyNames.in

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Generate shorthandForProperty() implementation from CSSPropertyNames.in. This is just a big switch() statement calling the right StylePropertyShorthand factory function for a given CSSPropertyID.

[Chris Dumez]

Created attachment 244791 [details]
Patch

[Chris Dumez]

Comment on attachment 244791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244791&action=review

> Source/WebCore/css/makeprop.pl:977
> +# FIXME: CSSPropertyFont is currently an exception. It is hard-coded here

I filed https://bugs.webkit.org/show_bug.cgi?id=140577 fo this.

[Darin Adler]

Comment on attachment 244791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244791&action=review

Some day we might want a table instead of a switch, if that proves to have better performance. If we know the numeric values of all the CSS property constants then we can just emit an array.

> Source/WebCore/css/makeprop.pl:964
> +    static NeverDestroyed<StylePropertyShorthand> emptyShorthand;

Seems like this could go right after the default: label instead of at the top of the function. Not sure it’s better, though. Or the empty shorthand could be a function, just like all the specific shorthands, rather than inlined here.

[WebKit Commit Bot]

Comment on attachment 244791 [details]
Patch

Clearing flags on attachment: 244791

Committed r178626: <http://trac.webkit.org/changeset/178626>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.