Bug 140555 - Web Inspector: code generator should fail on duplicate parameter and member names
Summary: Web Inspector: code generator should fail on duplicate parameter and member n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-01-16 12:11 PST by Brian Burg
Modified: 2015-01-16 13:40 PST (History)
8 users (show)

See Also:

Attachments
Patch (10.50 KB, patch)
2015-01-16 12:15 PST, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-01-16 12:11:11 PST 
I accidentally ran into this, and it failed during compilation instead of specification parsing. This is an easy fix.
Comment 1 Radar WebKit Bug Importer 2015-01-16 12:11:30 PST 
<rdar://problem/19502129>
Comment 2 Brian Burg 2015-01-16 12:15:20 PST 
Created attachment 244785 [details]
Patch
Comment 3 WebKit Commit Bot 2015-01-16 12:16:41 PST 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2015-01-16 13:40:21 PST 
Comment on attachment 244785 [details]
Patch

Clearing flags on attachment: 244785

Committed r178599: <http://trac.webkit.org/changeset/178599>
Comment 5 WebKit Commit Bot 2015-01-16 13:40:26 PST 
All reviewed patches have been landed.  Closing bug.