Bug 140547 - webkit-patch should auto-install the keyring python module
Summary: webkit-patch should auto-install the keyring python module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-16 10:45 PST by Chris Dumez
Modified: 2015-01-16 12:07 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2015-01-16 11:19 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-01-16 10:45:22 PST 
Every time I run webkit-patch it asks for my username / password. It never asks if it should save my username / password in the keychain.
I think the script should ask me if I want to save it and then do a "security add-internet-password ..." to store it in the keychain.

Note: I do not have the keyring python module installed.
Comment 1 Chris Dumez 2015-01-16 10:55:47 PST 
Looks like a solution would be to auto-install the keyring module. webkit-patch seems to be working fine for me with the keyring module installed.
Comment 2 Chris Dumez 2015-01-16 11:19:16 PST 
Created attachment 244776 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2015-01-16 11:21:56 PST 
Comment on attachment 244776 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2015-01-16 12:07:01 PST 
Comment on attachment 244776 [details]
Patch

Clearing flags on attachment: 244776

Committed r178589: <http://trac.webkit.org/changeset/178589>
Comment 5 WebKit Commit Bot 2015-01-16 12:07:18 PST 
All reviewed patches have been landed.  Closing bug.