Bug 140511 - Reduce LayoutRect::infiniteRect() usage.
Summary: Reduce LayoutRect::infiniteRect() usage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-15 13:56 PST by zalan
Modified: 2015-01-15 16:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.83 KB, patch)
2015-01-15 14:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.46 KB, patch)
2015-01-15 14:38 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.31 KB, patch)
2015-01-15 15:22 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-01-15 13:56:38 PST 
LayoutRect/FloatRect' infinite rect representation is highly error prone. The current representation of infiniteness can only cover half of the actual range (point=(nearlyMin()/2, nearlyMin()/2) (size=(nearlyMax(), nearlyMax())). With such limitation, a FloatPoint(nearlyMax() - 1, nearlyMax() - 1) does not intersect(contain) with the infinite FloatRect.
Comment 1 zalan 2015-01-15 14:12:40 PST 
Created attachment 244712 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-01-15 14:17:42 PST 
Comment on attachment 244712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244712&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:777
> +        ASSERT(parentClipRect.isInfinite());

!parentClipRect.isInfinite()
Comment 3 zalan 2015-01-15 14:38:00 PST 
Created attachment 244715 [details]
Patch
Comment 4 zalan 2015-01-15 15:22:25 PST 
Created attachment 244717 [details]
Patch
Comment 5 WebKit Commit Bot 2015-01-15 16:11:27 PST 
Comment on attachment 244717 [details]
Patch

Clearing flags on attachment: 244717

Committed r178541: <http://trac.webkit.org/changeset/178541>
Comment 6 WebKit Commit Bot 2015-01-15 16:11:34 PST 
All reviewed patches have been landed.  Closing bug.