NEW140508
Some console messages erroneously skip the first ScriptCallStack frame when computing source locations 
https://bugs.webkit.org/show_bug.cgi?id=140508
Summary Some console messages erroneously skip the first ScriptCallStack frame when c...
Brian Burg
Reported 2015-01-15 13:22:22 PST
These wrong line numbers were previously visible in test results, but with the fix to https://bugs.webkit.org/show_bug.cgi?id=140478 this will become more apparent. This may have been happening for console messages too, though I have no test case in hand. I suggest simplifying the logic in ConsoleMessage and ScriptCallStackFactory so that there is only one place that creates a ScriptCallStack. Clients can specifically ask for the first non-native call frame if that is necessary, i.e., when the native call frame shouldn't be shown in the console. There's no reason to decide whether to skip this when creating the call stack, as code paths already exist to filter out native frames.
Attachments
Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.