Bug 140495 - REGRESSION(r177876): Membuster regressed ~4%
Summary: REGRESSION(r177876): Membuster regressed ~4%
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-15 06:41 PST by Antti Koivisto
Modified: 2015-01-21 11:33 PST (History)
3 users (show)

See Also:


Attachments
patch (2.01 KB, patch)
2015-01-15 06:46 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff
patch (4.87 KB, patch)
2015-01-20 11:11 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-01-15 06:41:34 PST
Membuster regressed by the cache clearing patch.
Comment 1 Antti Koivisto 2015-01-15 06:46:59 PST
Created attachment 244692 [details]
patch
Comment 2 Andreas Kling 2015-01-15 10:34:20 PST
Comment on attachment 244692 [details]
patch

r=me
Comment 3 Antti Koivisto 2015-01-15 12:08:44 PST
https://trac.webkit.org/r178522
Comment 4 Antti Koivisto 2015-01-20 10:46:46 PST
That didn't fix it.
Comment 5 Antti Koivisto 2015-01-20 11:11:35 PST
Created attachment 245002 [details]
patch
Comment 6 Andreas Kling 2015-01-20 11:47:48 PST
Comment on attachment 245002 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245002&action=review

r=me

> Source/WebCore/platform/graphics/FontCascade.cpp:296
>      Vector<unsigned, 50> toRemove;
> -    FontGlyphsCache::iterator end = fontGlyphsCache().end();
> -    for (FontGlyphsCache::iterator it = fontGlyphsCache().begin(); it != end; ++it) {
> -        if (it->value->glyphs.get().hasOneRef())
> -            toRemove.append(it->key);
> +    for (auto& entry : fontGlyphsCache()) {
> +        if (entry.value->glyphs.get().hasOneRef())
> +            toRemove.append(entry.key);
>      }
>      for (unsigned i = 0; i < toRemove.size(); ++i)
>          fontGlyphsCache().remove(toRemove[i]);

Jesus man, just use removeIf(), it's not 2014 anymore.
Comment 7 Antti Koivisto 2015-01-21 11:33:35 PST
https://trac.webkit.org/r178853