WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140377
Basic block start offsets should never be larger than end offsets in the control flow profiler
https://bugs.webkit.org/show_bug.cgi?id=140377
Summary
Basic block start offsets should never be larger than end offsets in the cont...
Saam Barati
Reported
2015-01-12 17:03:43 PST
There are a few bugs where a basic block will be created with a start text offset that is larger than its end offset. This is wrong and needs to be fixed.
Attachments
patch
(17.84 KB, patch)
2015-01-15 11:35 PST
,
Saam Barati
fpizlo
: review+
Details
Formatted Diff
Diff
patch (check build)
(17.84 KB, patch)
2015-01-19 19:27 PST
,
Saam Barati
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2015-01-15 00:26:19 PST
This patch is actually turning into a fix that allows a single textual JavaScript statement to have its AST node instructions emitted multiple times and to not mess up the control flow profiler's computation of basic block boundaries.
Saam Barati
Comment 2
2015-01-15 00:27:35 PST
***
Bug 139287
has been marked as a duplicate of this bug. ***
Saam Barati
Comment 3
2015-01-15 11:35:56 PST
Created
attachment 244705
[details]
patch
WebKit Commit Bot
Comment 4
2015-01-15 11:38:34 PST
Attachment 244705
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:4082: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 5
2015-01-19 19:27:37 PST
Created
attachment 244952
[details]
patch (check build) making sure it builds everywhere
WebKit Commit Bot
Comment 6
2015-01-19 19:28:17 PST
Attachment 244952
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:4082: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 7
2015-01-19 20:48:25 PST
landed in:
http://trac.webkit.org/changeset/178692
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug