Bug 140324 - Make fast/css/first-letter-skip-out-of-flow.html a ref-test
Summary: Make fast/css/first-letter-skip-out-of-flow.html a ref-test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-09 16:06 PST by Manuel Rego Casasnovas
Modified: 2015-01-12 14:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (58.72 KB, patch)
2015-01-09 16:07 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch for landing (58.71 KB, patch)
2015-01-12 13:57 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2015-01-09 16:06:46 PST 
Make fast/css/first-letter-skip-out-of-flow-expected.html a ref-test
Comment 1 Manuel Rego Casasnovas 2015-01-09 16:07:55 PST 
Created attachment 244384 [details]
Patch
Comment 2 Andreas Kling 2015-01-12 13:04:27 PST 
Comment on attachment 244384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244384&action=review

r=me

> LayoutTests/ChangeLog:3
> +        Make fast/css/first-letter-skip-out-of-flow-expected.html a ref-test

The title should really be "Make fast/css/first-letter-skip-out-of-flow.html a ref-test" :)
Comment 3 Manuel Rego Casasnovas 2015-01-12 13:54:34 PST 
(In reply to comment #2)
> Comment on attachment 244384 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244384&action=review
> 
> r=me

Thanks for the review.

> > LayoutTests/ChangeLog:3
> > +        Make fast/css/first-letter-skip-out-of-flow-expected.html a ref-test
> 
> The title should really be "Make fast/css/first-letter-skip-out-of-flow.html
> a ref-test" :)

Yes, sure!
Comment 4 Manuel Rego Casasnovas 2015-01-12 13:57:42 PST 
Created attachment 244465 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2015-01-12 14:40:29 PST 
Comment on attachment 244465 [details]
Patch for landing

Clearing flags on attachment: 244465

Committed r178299: <http://trac.webkit.org/changeset/178299>
Comment 6 WebKit Commit Bot 2015-01-12 14:40:33 PST 
All reviewed patches have been landed.  Closing bug.