Bug 140285 – [CoordinatedGraphics] Suspend or resume when visibility is changed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

When webview became hidden, I think that we don't need to draw something like TiledCoreAnimationDrawingArea in mac/

[Ryuan Choi]

Created attachment 244326 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 244326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244326&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:613
> +    if (changed && ViewState::IsVisible) {

Is changed flag ? So don't we use below condition ?

if (changed & ViewState::IsVisible) {

}

[Ryuan Choi]

Created attachment 244330 [details]
Patch

[Ryuan Choi]

(In reply to comment #2)
> Comment on attachment 244326 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244326&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:613
> > +    if (changed && ViewState::IsVisible) {
> 
> Is changed flag ? So don't we use below condition ?
> 
> if (changed & ViewState::IsVisible) {
> 
> }

Oops, mistake.

Thanks for the review, I fixed.

[WebKit Commit Bot]

Comment on attachment 244330 [details]
Patch

Clearing flags on attachment: 244330

Committed r178252: <http://trac.webkit.org/changeset/178252>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.