Bug 140225 - [GTK] Build gtk-doc without gtkdoc-mktmpl
Summary: [GTK] Build gtk-doc without gtkdoc-mktmpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-07 16:16 PST by Michael Catanzaro
Modified: 2015-01-07 22:00 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2015-01-07 16:22 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-01-07 16:16:46 PST
gtkdoc-mktmpl is being removed upstream [1], so we should stop using it. We were not using the tmpl files at all, so this is really easy: we just need to not call it at all. (It generates files that were intended to be manually edited and checked into version control. Since we didn't edit them, they weren't doing anything.)

This would be a good candidate for a backport to the 2.4 branch.

[1] https://mail.gnome.org/archives/desktop-devel-list/2014-December/msg00023.html
Comment 1 Michael Catanzaro 2015-01-07 16:22:08 PST
Created attachment 244218 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-07 22:00:54 PST
Comment on attachment 244218 [details]
Patch

Clearing flags on attachment: 244218

Committed r178103: <http://trac.webkit.org/changeset/178103>
Comment 3 WebKit Commit Bot 2015-01-07 22:00:59 PST
All reviewed patches have been landed.  Closing bug.