Bug 140126 - Add a WebKit1 database provider
Summary: Add a WebKit1 database provider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 140136
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-06 09:35 PST by Anders Carlsson
Modified: 2015-01-06 14:17 PST (History)
4 users (show)

See Also:

Attachments
Patch (20.14 KB, patch)
2015-01-06 09:37 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-01-06 09:35:27 PST 
Add a WebKit1 database provider
Comment 1 Anders Carlsson 2015-01-06 09:37:22 PST 
Created attachment 244068 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-06 09:40:40 PST 
Attachment 244068 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebDatabaseProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-01-06 09:53:28 PST 
Committed r177963: <http://trac.webkit.org/changeset/177963>
Comment 4 WebKit Commit Bot 2015-01-06 11:39:01 PST 
Re-opened since this is blocked by bug 140136
Comment 5 Anders Carlsson 2015-01-06 12:09:53 PST 
Committed r177985: <http://trac.webkit.org/changeset/177985>
Comment 6 Chris Dumez 2015-01-06 14:17:25 PST 
Seems to have caused a regression:
rdar://problem/19390383