Bug 140005 - Fix build warnings after r177792
Summary: Fix build warnings after r177792
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 139978
  Show dependency tree / graph
 
Reported: 2014-12-30 04:19 PST by Bartlomiej Gajda
Modified: 2014-12-31 09:17 PST (History)
4 users (show)

See Also:

Attachments
patch v1 (3.36 KB, patch)
2014-12-30 04:23 PST, Bartlomiej Gajda 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bartlomiej Gajda 2014-12-30 04:19:26 PST 
After that revision following errors appeared:
DerivedSources/WebKit2/NetworkResourceLoaderMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/PluginProcessMessageReceiver.cpp:41:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/NetworkProcessMessageReceiver.cpp:50:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/NetworkConnectionToWebProcessMessageReceiver.cpp:80:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/WebProcessConnectionMessageReceiver.cpp:87:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/PluginControllerProxyMessageReceiver.cpp:74:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/WebFullScreenManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/WebProcessProxyMessageReceiver.cpp:132:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/NetworkProcessConnectionMessageReceiver.cpp:49:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/PluginProcessConnectionMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/WebProcessMessageReceiver.cpp:51:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/WebResourceLoaderMessageReceiver.cpp:48:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/PluginProxyMessageReceiver.cpp:45:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/CoordinatedLayerTreeHostMessageReceiver.cpp:41:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
DerivedSources/WebKit2/WebPageMessageReceiver.cpp:128:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
Comment 1 Bartlomiej Gajda 2014-12-30 04:23:25 PST 
Created attachment 243821 [details]
patch v1

The most important part is to add UNUSED_PARAM even if it's LegacyReceiver, but I also refactored a bit code around, so there are no unneccessary ifs.
Comment 2 WebKit Commit Bot 2014-12-31 09:17:00 PST 
Comment on attachment 243821 [details]
patch v1

Clearing flags on attachment: 243821

Committed r177833: <http://trac.webkit.org/changeset/177833>
Comment 3 WebKit Commit Bot 2014-12-31 09:17:04 PST 
All reviewed patches have been landed.  Closing bug.