WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140005
Fix build warnings after
r177792
https://bugs.webkit.org/show_bug.cgi?id=140005
Summary
Fix build warnings after r177792
Bartlomiej Gajda
Reported
2014-12-30 04:19:26 PST
After that revision following errors appeared: DerivedSources/WebKit2/NetworkResourceLoaderMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/PluginProcessMessageReceiver.cpp:41:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/NetworkProcessMessageReceiver.cpp:50:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/NetworkConnectionToWebProcessMessageReceiver.cpp:80:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebProcessConnectionMessageReceiver.cpp:87:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/PluginControllerProxyMessageReceiver.cpp:74:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebFullScreenManagerMessageReceiver.cpp:37:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebProcessProxyMessageReceiver.cpp:132:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/NetworkProcessConnectionMessageReceiver.cpp:49:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/PluginProcessConnectionMessageReceiver.cpp:39:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebProcessMessageReceiver.cpp:51:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebResourceLoaderMessageReceiver.cpp:48:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/PluginProxyMessageReceiver.cpp:45:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/CoordinatedLayerTreeHostMessageReceiver.cpp:41:6: warning: unused parameter ‘connection’ [-Wunused-parameter] DerivedSources/WebKit2/WebPageMessageReceiver.cpp:128:6: warning: unused parameter ‘connection’ [-Wunused-parameter]
Attachments
patch v1
(3.36 KB, patch)
2014-12-30 04:23 PST
,
Bartlomiej Gajda
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Bartlomiej Gajda
Comment 1
2014-12-30 04:23:25 PST
Created
attachment 243821
[details]
patch v1 The most important part is to add UNUSED_PARAM even if it's LegacyReceiver, but I also refactored a bit code around, so there are no unneccessary ifs.
WebKit Commit Bot
Comment 2
2014-12-31 09:17:00 PST
Comment on
attachment 243821
[details]
patch v1 Clearing flags on attachment: 243821 Committed
r177833
: <
http://trac.webkit.org/changeset/177833
>
WebKit Commit Bot
Comment 3
2014-12-31 09:17:04 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug