Bug 139936 - ANGLE extern symbols are not hidden by default, but should be
Summary: ANGLE extern symbols are not hidden by default, but should be
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks: 136172
  Show dependency tree / graph
 
Reported: 2014-12-24 14:46 PST by mitz
Modified: 2014-12-24 15:10 PST (History)
8 users (show)

See Also:

Attachments
Change GCC_SYMBOLS_PRIVATE_EXTERN to YES (1.21 KB, patch)
2014-12-24 14:50 PST, mitz 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-12-24 14:46:35 PST 
Once WebCore stops using an exports file, the default visibility of ANGLE symbols will carry over to WebCore. WebCore shouldn’t export any ANGLE symbols, so ANGLE should build with -fvisibility=hidden.
Comment 1 mitz 2014-12-24 14:50:28 PST 
Created attachment 243729 [details]
Change GCC_SYMBOLS_PRIVATE_EXTERN to YES
Comment 2 WebKit Commit Bot 2014-12-24 14:53:21 PST 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 mitz 2014-12-24 15:10:33 PST 
Fixed in <http://trac.webkit.org/r177724>.