WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139936
ANGLE extern symbols are not hidden by default, but should be
https://bugs.webkit.org/show_bug.cgi?id=139936
Summary
ANGLE extern symbols are not hidden by default, but should be
mitz
Reported
2014-12-24 14:46:35 PST
Once WebCore stops using an exports file, the default visibility of ANGLE symbols will carry over to WebCore. WebCore shouldn’t export any ANGLE symbols, so ANGLE should build with -fvisibility=hidden.
Attachments
Change GCC_SYMBOLS_PRIVATE_EXTERN to YES
(1.21 KB, patch)
2014-12-24 14:50 PST
,
mitz
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
2014-12-24 14:50:28 PST
Created
attachment 243729
[details]
Change GCC_SYMBOLS_PRIVATE_EXTERN to YES
WebKit Commit Bot
Comment 2
2014-12-24 14:53:21 PST
Note that there are important steps to take when updating ANGLE. See
http://trac.webkit.org/wiki/UpdatingANGLE
mitz
Comment 3
2014-12-24 15:10:33 PST
Fixed in <
http://trac.webkit.org/r177724
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug