WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139917
Rename ImmutableDictionary to API::Dictionary and merge MutableDictionary into it
https://bugs.webkit.org/show_bug.cgi?id=139917
Summary
Rename ImmutableDictionary to API::Dictionary and merge MutableDictionary int...
Sam Weinig
Reported
2014-12-23 14:33:17 PST
Rename ImmutableDictionary to API::Dictionary and merge MutableDictionary into it
Attachments
Patch
(93.19 KB, patch)
2014-12-23 14:39 PST
,
Sam Weinig
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2014-12-23 14:39:18 PST
Created
attachment 243694
[details]
Patch
WebKit Commit Bot
Comment 2
2014-12-23 14:41:19 PST
Attachment 243694
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebProcessPool.cpp:1329: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/Cocoa/WKNSDictionary.h:34: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/Shared/API/c/WKSharedAPICast.h:118: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebKit2/UIProcess/WebProcessPool.h:279: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2014-12-23 15:07:42 PST
Committed
r177699
: <
http://trac.webkit.org/changeset/177699
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug