Bug 139783 - Web Inspector: ASSERT seen closing/opening multiple inspectors
Summary: Web Inspector: ASSERT seen closing/opening multiple inspectors
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2014-12-18 11:21 PST by Joseph Pecoraro
Modified: 2014-12-18 12:45 PST (History)
8 users (show)

See Also:

[PATCH] Proposed Fix (1.29 KB, patch)
2014-12-18 11:22 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-12-18 11:21:28 PST
I occasionally see this assert in Inspector code when opening/closing multiple inspectors repeatedly in Debug builds.

    Deprecated::ScriptValue InjectedScript::findObjectById(const String& objectId) const

We can safely avoid calling findObjectById if we have an empty InjectedScript.
Comment 1 Radar WebKit Bug Importer 2014-12-18 11:22:06 PST
Comment 2 Joseph Pecoraro 2014-12-18 11:22:19 PST
Created attachment 243504 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-12-18 12:45:24 PST
Comment on attachment 243504 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 243504

Committed r177518: <http://trac.webkit.org/changeset/177518>
Comment 4 WebKit Commit Bot 2014-12-18 12:45:28 PST
All reviewed patches have been landed.  Closing bug.