Bug 139624 - Ruby overhang uses ints instead of floats
Summary: Ruby overhang uses ints instead of floats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-13 13:45 PST by Myles C. Maxfield
Modified: 2014-12-17 17:43 PST (History)
9 users (show)

See Also:


Attachments
Patch (672.69 KB, patch)
2014-12-16 13:46 PST, Myles C. Maxfield
hyatt: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-mountainlion-wk2 (991.72 KB, application/zip)
2014-12-16 14:33 PST, Build Bot
no flags Details
Archive of layout-test-results from ews103 for mac-mountainlion (993.51 KB, application/zip)
2014-12-16 14:36 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-12-13 13:45:57 PST
See RenderRubyRun::getOverhang()
Comment 1 Myles C. Maxfield 2014-12-16 13:46:25 PST
Created attachment 243388 [details]
Patch
Comment 2 Dave Hyatt 2014-12-16 13:47:29 PST
Comment on attachment 243388 [details]
Patch

r=me
Comment 3 Build Bot 2014-12-16 14:33:11 PST
Comment on attachment 243388 [details]
Patch

Attachment 243388 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5253269886599168

New failing tests:
fast/writing-mode/Kusa-Makura-background-canvas.html
Comment 4 Build Bot 2014-12-16 14:33:15 PST
Created attachment 243396 [details]
Archive of layout-test-results from ews107 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-12-16 14:36:08 PST
Comment on attachment 243388 [details]
Patch

Attachment 243388 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6614031490088960

New failing tests:
fast/writing-mode/Kusa-Makura-background-canvas.html
Comment 6 Build Bot 2014-12-16 14:36:11 PST
Created attachment 243397 [details]
Archive of layout-test-results from ews103 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Myles C. Maxfield 2014-12-16 14:52:34 PST
Committed r177398: <http://trac.webkit.org/changeset/177398>
Comment 8 Radar WebKit Bug Importer 2014-12-17 17:43:02 PST
<rdar://problem/19288367>