Bug 139610 - Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
Summary: Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed prop...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-12 17:52 PST by Joseph Pecoraro
Modified: 2014-12-15 16:00 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.85 KB, patch)
2014-12-12 17:54 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-12-12 17:52:01 PST 
* SUMMARY
CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty.

No steps to reproduce, this requires a CSSAgent.getComputedStyleForNode to return an empty list, followed by a non-empty list later. However, that said, it seems this seems like a bug worth fixing now instead of later.
Comment 1 Joseph Pecoraro 2014-12-12 17:54:41 PST 
Created attachment 243237 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-12-15 16:00:48 PST 
Comment on attachment 243237 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 243237

Committed r177322: <http://trac.webkit.org/changeset/177322>
Comment 3 WebKit Commit Bot 2014-12-15 16:00:51 PST 
All reviewed patches have been landed.  Closing bug.