Bug 139559 - bmalloc should support system memory analysis tools (part 1)
Summary: bmalloc should support system memory analysis tools (part 1)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-11 13:09 PST by Geoffrey Garen
Modified: 2014-12-11 14:16 PST (History)
5 users (show)

See Also:

Attachments
Patch (17.82 KB, patch)
2014-12-11 13:16 PST, Geoffrey Garen 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2014-12-11 13:09:06 PST 
bmalloc should support system memory analysis tools (part 1)
Comment 1 Geoffrey Garen 2014-12-11 13:16:16 PST 
Created attachment 243142 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-11 13:17:57 PST 
Attachment 243142 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/VMHeap.cpp:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/bmalloc/bmalloc/Environment.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2014-12-11 13:58:19 PST 
Comment on attachment 243142 [details]
Patch

r=me
Comment 4 Geoffrey Garen 2014-12-11 14:16:26 PST 
Committed r177181: <http://trac.webkit.org/changeset/177181>