Bug 139523 - Web Inspector: debugger should not require multiple "step over" commands to step past 'return' statement
Summary: Web Inspector: debugger should not require multiple "step over" commands to s...
Status: RESOLVED DUPLICATE of bug 155325
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-10 18:46 PST by Brian Burg
Modified: 2016-09-30 16:42 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-12-10 18:46:10 PST
Steps to repro:

1. Pause inside a function with |return <expr>;| on the last line.
2. Step over each statement until the return.
3. Step over the return statement.

At the end of step 3, the debugger is stepped "past" the return statement. How this is shown to the user seems inconsistent.
Sometimes, the debugger implicitly "steps out" to the callee's call frame, while other times it seems to step past the return statement without stepping out.

I haven't peeked at the protocol traffic to see what commands are actually being emitted. It may be the case that some of the step over clicks were not being sent to the backend somehow. To prevent this sort of race, we could add a debouncing animation to the stepping buttons that makes it clearer when the debugger command has been processed.
Comment 1 Radar WebKit Bug Importer 2014-12-17 11:21:26 PST
<rdar://problem/19281478>
Comment 2 Joseph Pecoraro 2016-09-12 12:21:20 PDT
I have a fix for this. I'll likely duplicate to a more general bug addressing many stepping issues.
Comment 3 Joseph Pecoraro 2016-09-30 16:42:30 PDT
Fixed by: bug 155325
<https://trac.webkit.org/changeset/206652>

*** This bug has been marked as a duplicate of bug 155325 ***