Bug 139450 - [GTK] Minor fixes for documentation and translations
Summary: [GTK] Minor fixes for documentation and translations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-09 10:59 PST by Tomas Popela
Modified: 2014-12-11 13:17 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.15 KB, patch)
2014-12-09 11:05 PST, Tomas Popela 		no flags Details | Formatted Diff | Diff
Patch (4.01 KB, patch)
2014-12-10 00:14 PST, Tomas Popela 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2014-12-09 10:59:13 PST 
Fix a mistype in documentation, mark the zoom-level and is-loading properties name for translation when touching their defition also fix their indentation style.
Comment 1 Tomas Popela 2014-12-09 11:05:22 PST 
Created attachment 242941 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-09 11:06:18 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2014-12-09 16:32:19 PST 
Comment on attachment 242941 [details]
Patch

Rejecting attachment 242941 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242941, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 177042 = a4b0e9806d0f0c4133be110a1a48c4263c7f7231
r177043 = 54e0b7791c859b2019909f9834db550218b06649
r177044 = 5918955cc12fa7ae10897228b3ce6cd85d2dd080
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5438752612679680
Comment 4 Martin Robinson 2014-12-09 16:44:50 PST 
Comment on attachment 242941 [details]
Patch

Oops. This patch is missing a ChangeLog. If you use webkit-patch to upload your patch to bugzilla it will take care of this for you.
Comment 5 Tomas Popela 2014-12-10 00:07:32 PST 
(In reply to comment #4)
> Comment on attachment 242941 [details]
> Patch
> 
> Oops. This patch is missing a ChangeLog. If you use webkit-patch to upload
> your patch to bugzilla it will take care of this for you.

Hmm I used the webkit-patch to upload it.. I will do it again..
Comment 6 Tomas Popela 2014-12-10 00:14:18 PST 
Created attachment 242991 [details]
Patch
Comment 7 Sergio Villar Senin 2014-12-11 02:28:37 PST 
Comment on attachment 242991 [details]
Patch

At some point we should address the inconsistencies in the properties definitions inside those files, for example we have different indentations, we use camel case in some property descriptions and not in others...
Comment 8 WebKit Commit Bot 2014-12-11 13:17:11 PST 
Comment on attachment 242991 [details]
Patch

Clearing flags on attachment: 242991

Committed r177177: <http://trac.webkit.org/changeset/177177>
Comment 9 WebKit Commit Bot 2014-12-11 13:17:14 PST 
All reviewed patches have been landed.  Closing bug.