Bug 139450 – [GTK] Minor fixes for documentation and translations

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Tomas Popela]

Fix a mistype in documentation, mark the zoom-level and is-loading properties name for translation when touching their defition also fix their indentation style.

[Tomas Popela]

Created attachment 242941 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Commit Bot]

Comment on attachment 242941 [details]
Patch

Rejecting attachment 242941 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242941, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 177042 = a4b0e9806d0f0c4133be110a1a48c4263c7f7231
r177043 = 54e0b7791c859b2019909f9834db550218b06649
r177044 = 5918955cc12fa7ae10897228b3ce6cd85d2dd080
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5438752612679680

[Martin Robinson]

Comment on attachment 242941 [details]
Patch

Oops. This patch is missing a ChangeLog. If you use webkit-patch to upload your patch to bugzilla it will take care of this for you.

[Tomas Popela]

(In reply to comment #4)
> Comment on attachment 242941 [details]
> Patch
> 
> Oops. This patch is missing a ChangeLog. If you use webkit-patch to upload
> your patch to bugzilla it will take care of this for you.

Hmm I used the webkit-patch to upload it.. I will do it again..

[Tomas Popela]

Created attachment 242991 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 242991 [details]
Patch

At some point we should address the inconsistencies in the properties definitions inside those files, for example we have different indentations, we use camel case in some property descriptions and not in others...

[WebKit Commit Bot]

Comment on attachment 242991 [details]
Patch

Clearing flags on attachment: 242991

Committed r177177: <http://trac.webkit.org/changeset/177177>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.