Bug 139427 - Remove virtual test support from webkitpy
Summary: Remove virtual test support from webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-08 21:34 PST by Benjamin Poulain
Modified: 2014-12-09 12:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (18.60 KB, patch)
2014-12-08 21:35 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-12-08 21:34:02 PST 
Remove virtual test support from webkitpy
Comment 1 Benjamin Poulain 2014-12-08 21:35:20 PST 
Created attachment 242879 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-12-08 23:33:01 PST 
I'm curious what virtual tests were!
Comment 3 Benjamin Poulain 2014-12-08 23:34:57 PST 
(In reply to comment #2)
> I'm curious what virtual tests were!

From a tiny bit of git blame that seemed like a bunch of chromium tests. I don't know what was tested.
Comment 4 Alexey Proskuryakov 2014-12-08 23:57:33 PST 
What made me curious was a thought about whether we could use this to split huge slow tests that frequently time out (notably jquery) into tiny virtual tests.
Comment 5 Csaba Osztrogonác 2014-12-09 02:21:00 PST 
http://www.chromium.org/developers/testing/webkit-layout-tests describes
that virtual tests are to run tests with different DRT command line options.
Comment 6 Alexey Proskuryakov 2014-12-09 09:37:56 PST 
Comment on attachment 242879 [details]
Patch

Thank you! Sounds like a good thing to remove, rs=me.
Comment 7 Benjamin Poulain 2014-12-09 12:49:37 PST 
Comment on attachment 242879 [details]
Patch

Clearing flags on attachment: 242879

Committed r177034: <http://trac.webkit.org/changeset/177034>
Comment 8 Benjamin Poulain 2014-12-09 12:49:40 PST 
All reviewed patches have been landed.  Closing bug.