WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139358
[SOUP] Layout test http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html fails
https://bugs.webkit.org/show_bug.cgi?id=139358
Summary
[SOUP] Layout test http/tests/misc/authentication-redirect-3/authentication-s...
Carlos Alberto Lopez Perez
Reported
2014-12-07 04:16:20 PST
Since
r176752
<
http://trac.webkit.org/r176752
> the layout test http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html is failing on platform GTK. The diff is (after 176757 <
http://trac.webkit.org/176757
>):
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r176761%20%284606%29/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-pretty-diff.html
Attachments
Patch
(3.95 KB, patch)
2016-11-04 07:42 PDT
,
Carlos Garcia Campos
mcatanzaro
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2014-12-07 08:15:09 PST
Marked accordingly on the GTK expectations on
https://trac.webkit.org/r176922
Alexey Proskuryakov
Comment 2
2014-12-07 09:49:01 PST
Does Gtk have custom results for this test? I wonder if it actually started to pass.
Carlos Alberto Lopez Perez
Comment 3
2014-12-07 10:27:01 PST
(In reply to
comment #2
)
> Does Gtk have custom results for this test? I wonder if it actually started > to pass.
It don't has (AFAIK). It is using the expected file for WK2 <LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt> that was added on 176757 <
http://trac.webkit.org/176757
>
Carlos Garcia Campos
Comment 4
2016-11-04 07:37:18 PDT
The diff at that time is no longer available, so I don't know if we are still failing for the same reason, but what I know id the reason why we currently do this wrong is not a regression introduced in
r176752
. The problem is that credentials cached in WebCore take precedence over credentials provided in the URL in case of redirection.
Carlos Garcia Campos
Comment 5
2016-11-04 07:42:40 PDT
Created
attachment 293887
[details]
Patch
Carlos Garcia Campos
Comment 6
2016-11-05 00:59:58 PDT
Committed
r208416
: <
http://trac.webkit.org/changeset/208416
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug