Bug 138982 - WebVideoFullscreenManagerProxy must clear pointers when invalidated
Summary: WebVideoFullscreenManagerProxy must clear pointers when invalidated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-21 14:51 PST by Eric Carlson
Modified: 2014-11-21 16:55 PST (History)
5 users (show)

See Also:


Attachments
Proposed patch. (1.75 KB, patch)
2014-11-21 14:57 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-11-21 14:51:15 PST
WebVideoFullscreenManagerProxy::invalidate is called when the page is about to close, so it should clear the WebVideoFullscreenModel and WebVideoFullscreenChangeObserver.
Comment 1 Eric Carlson 2014-11-21 14:51:30 PST
rdar://problem/18904411
Comment 2 Eric Carlson 2014-11-21 14:57:43 PST
Created attachment 242074 [details]
Proposed patch.
Comment 3 WebKit Commit Bot 2014-11-21 16:55:34 PST
Comment on attachment 242074 [details]
Proposed patch.

Clearing flags on attachment: 242074

Committed r176487: <http://trac.webkit.org/changeset/176487>
Comment 4 WebKit Commit Bot 2014-11-21 16:55:39 PST
All reviewed patches have been landed.  Closing bug.