Bug 138956 - Implement yellow highlight for WebKit1 data detectors
Summary: Implement yellow highlight for WebKit1 data detectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-21 03:00 PST by Tim Horton
Modified: 2014-12-01 17:50 PST (History)
7 users (show)

See Also:

Attachments
Patch (11.36 KB, patch)
2014-11-21 03:00 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (27.26 KB, patch)
2014-11-22 00:05 PST, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-21 03:00:00 PST 
Implement yellow highlight for WebKit1 data detectors
Comment 1 Tim Horton 2014-11-21 03:00:28 PST 
Created attachment 242033 [details]
Patch
Comment 2 Tim Horton 2014-11-21 03:01:15 PST 
This depends on https://bugs.webkit.org/show_bug.cgi?id=138954 so it will not build.
Comment 3 WebKit Commit Bot 2014-11-21 03:03:19 PST 
Attachment 242033 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:8567:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/mac/WebView/WebViewInternal.h:259:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-11-21 12:31:50 PST 
This needs some adjustments just like https://bugs.webkit.org/show_bug.cgi?id=138955
Comment 5 Tim Horton 2014-11-22 00:05:59 PST 
Created attachment 242115 [details]
Patch
Comment 6 Tim Horton 2014-11-22 00:06:19 PST 
<rdar://problem/18992185>
Comment 7 WebKit Commit Bot 2014-11-22 00:07:38 PST 
Attachment 242115 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:8569:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/mac/WebView/WebViewInternal.h:260:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Tim Horton 2014-12-01 12:48:21 PST 
http://trac.webkit.org/changeset/176599
Comment 9 Tim Horton 2014-12-01 15:56:32 PST 
iOS build fixes in http://trac.webkit.org/changeset/176608
Comment 10 Tim Horton 2014-12-01 17:50:54 PST 
Mac build fixes in http://trac.webkit.org/changeset/176618