Bug 138924 - Fix the !ENABLE(SVG_FONTS) build after r176276
Summary: Fix the !ENABLE(SVG_FONTS) build after r176276
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 138686
  Show dependency tree / graph
 
Reported: 2014-11-20 04:35 PST by Csaba Osztrogonác
Modified: 2014-11-20 13:45 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2014-11-20 13:02 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-11-20 04:35:51 PST 
build log:
../../Source/WebCore/css/CSSFontFaceSource.cpp:127:47: error: 'm_hasExternalSVGFont' was not declared in this scope
../../Source/WebCore/css/CSSFontFaceSource.cpp:130:103: error: 'm_hasExternalSVGFont' was not declared in this scope

m_hasExternalSVGFont is declared inside ENABLE(SVG_FONTS) guard, but used unconditionally here.
Comment 1 Csaba Osztrogonác 2014-11-20 04:39:41 PST 
more build error after this change:
../../Source/WebCore/loader/cache/CachedResourceLoader.cpp:186:25: error: 'CachedSVGFont' was not declared in this scope
../../Source/WebCore/loader/cache/CachedResourceLoader.cpp:186:56: error: 'SVGFontResource' is not a member of 'WebCore::CachedResource'
Comment 2 Myles C. Maxfield 2014-11-20 13:02:19 PST 
Created attachment 241972 [details]
Patch
Comment 3 Csaba Osztrogonác 2014-11-20 13:08:34 PST 
Comment on attachment 241972 [details]
Patch

Thanks, rs=me.
Comment 4 WebKit Commit Bot 2014-11-20 13:45:44 PST 
Comment on attachment 241972 [details]
Patch

Clearing flags on attachment: 241972

Committed r176410: <http://trac.webkit.org/changeset/176410>
Comment 5 WebKit Commit Bot 2014-11-20 13:45:49 PST 
All reviewed patches have been landed.  Closing bug.