WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
138924
Fix the !ENABLE(SVG_FONTS) build after
r176276
https://bugs.webkit.org/show_bug.cgi?id=138924
Summary
Fix the !ENABLE(SVG_FONTS) build after r176276
Csaba Osztrogonác
Reported
2014-11-20 04:35:51 PST
build log: ../../Source/WebCore/css/CSSFontFaceSource.cpp:127:47: error: 'm_hasExternalSVGFont' was not declared in this scope ../../Source/WebCore/css/CSSFontFaceSource.cpp:130:103: error: 'm_hasExternalSVGFont' was not declared in this scope m_hasExternalSVGFont is declared inside ENABLE(SVG_FONTS) guard, but used unconditionally here.
Attachments
Patch
(2.76 KB, patch)
2014-11-20 13:02 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2014-11-20 04:39:41 PST
more build error after this change: ../../Source/WebCore/loader/cache/CachedResourceLoader.cpp:186:25: error: 'CachedSVGFont' was not declared in this scope ../../Source/WebCore/loader/cache/CachedResourceLoader.cpp:186:56: error: 'SVGFontResource' is not a member of 'WebCore::CachedResource'
Myles C. Maxfield
Comment 2
2014-11-20 13:02:19 PST
Created
attachment 241972
[details]
Patch
Csaba Osztrogonác
Comment 3
2014-11-20 13:08:34 PST
Comment on
attachment 241972
[details]
Patch Thanks, rs=me.
WebKit Commit Bot
Comment 4
2014-11-20 13:45:44 PST
Comment on
attachment 241972
[details]
Patch Clearing flags on attachment: 241972 Committed
r176410
: <
http://trac.webkit.org/changeset/176410
>
WebKit Commit Bot
Comment 5
2014-11-20 13:45:49 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug