Bug 138852 - Use of uninitialized value in string eq in many http tests
Summary: Use of uninitialized value in string eq in many http tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-18 16:27 PST by Alexey Proskuryakov
Modified: 2014-11-18 21:41 PST (History)
1 user (show)

See Also:


Attachments
proposed fix (1.52 KB, patch)
2014-11-18 16:31 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-11-18 16:27:53 PST
LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl is a script shared by many tests that emits an error when used.
Comment 1 Alexey Proskuryakov 2014-11-18 16:31:28 PST
Created attachment 241830 [details]
proposed fix
Comment 2 Daniel Bates 2014-11-18 17:05:02 PST
Comment on attachment 241830 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=241830&action=review

> LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl:68
> +if (defined($cgi->param('csp'))) {

Alternatively you could define a local variable

my $contentSecurityPolicy = $cgi->param('cap') || "";

Then make use of this variable.
Comment 3 WebKit Commit Bot 2014-11-18 21:41:07 PST
Comment on attachment 241830 [details]
proposed fix

Clearing flags on attachment: 241830

Committed r176309: <http://trac.webkit.org/changeset/176309>
Comment 4 WebKit Commit Bot 2014-11-18 21:41:10 PST
All reviewed patches have been landed.  Closing bug.