Bug 138824 - Update the Vector API to deal with unsigned types instead of size_t
Summary: Update the Vector API to deal with unsigned types instead of size_t
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-17 23:19 PST by Chris Dumez
Modified: 2014-11-18 11:55 PST (History)
5 users (show)

See Also:

Attachments
WIP Patch (84.17 KB, patch)
2014-11-17 23:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (84.73 KB, patch)
2014-11-17 23:41 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (90.98 KB, patch)
2014-11-18 09:40 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-17 23:19:31 PST 
Update the Vector API to deal with unsigned types instead of size_t. Vector already uses unsigned for its size / capacity members but the API was never updated accordingly.
Comment 1 Chris Dumez 2014-11-17 23:37:06 PST 
Created attachment 241768 [details]
WIP Patch
Comment 2 WebKit Commit Bot 2014-11-17 23:38:09 PST 
Attachment 241768 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Vector.h:199:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-11-17 23:41:31 PST 
Created attachment 241769 [details]
WIP Patch
Comment 4 Chris Dumez 2014-11-18 09:40:56 PST 
Created attachment 241792 [details]
Patch
Comment 5 Andreas Kling 2014-11-18 11:17:58 PST 
Comment on attachment 241792 [details]
Patch

I owe you a $beverage! r=me
Comment 6 WebKit Commit Bot 2014-11-18 11:55:54 PST 
Comment on attachment 241792 [details]
Patch

Clearing flags on attachment: 241792

Committed r176275: <http://trac.webkit.org/changeset/176275>
Comment 7 WebKit Commit Bot 2014-11-18 11:55:59 PST 
All reviewed patches have been landed.  Closing bug.