Bug 138795 - [WinCairo] Compile error, CoreGraphics header file included.
Summary: [WinCairo] Compile error, CoreGraphics header file included.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-17 07:13 PST by peavo
Modified: 2014-11-17 10:58 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.27 KB, patch)
2014-11-17 07:18 PST, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-11-17 07:13:24 PST
CoreGraphics is not available on WinCairo.
Comment 1 peavo 2014-11-17 07:18:55 PST
Created attachment 241710 [details]
Patch
Comment 2 Myles C. Maxfield 2014-11-17 07:39:23 PST
Unofficial r=me
Comment 3 Brent Fulgham 2014-11-17 07:52:15 PST
Comment on attachment 241710 [details]
Patch

R=me
Comment 4 peavo 2014-11-17 08:37:42 PST
Thanks for reviewing :)

Does the patch also need a r+, or will it be committed anyway?
Comment 5 Brent Fulgham 2014-11-17 10:21:20 PST
Comment on attachment 241710 [details]
Patch

Grumble. I reviewed from my phone, and I guess I lost the r+ when I set the cq+. Setting both again!
Comment 6 peavo 2014-11-17 10:25:50 PST
(In reply to comment #5)
> Comment on attachment 241710 [details]
> Patch
> 
> Grumble. I reviewed from my phone, and I guess I lost the r+ when I set the
> cq+. Setting both again!

Thanks :)
Comment 7 WebKit Commit Bot 2014-11-17 10:58:52 PST
Comment on attachment 241710 [details]
Patch

Clearing flags on attachment: 241710

Committed r176210: <http://trac.webkit.org/changeset/176210>
Comment 8 WebKit Commit Bot 2014-11-17 10:58:57 PST
All reviewed patches have been landed.  Closing bug.