Bug 138787 – [iOS] allow host application to opt-out of alternate fullscreen

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Allow the host application to enable/disable alternate ("optimized") fullscreen mode.

[Eric Carlson]

<rdar://problem/18687640>

[Eric Carlson]

Created attachment 241686 [details]
Proposed patch.

[WebKit Commit Bot]

Attachment 241686 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 241686 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241686&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

You’ll have to remove this line. Or replace it with an explanation of why we didn’t add a test for this.

[Eric Carlson]

Committed r176199: https://trac.webkit.org/r176199

Comment on attachment 241686 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241686&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h:108
> +@property (nonatomic) BOOL allowsAlternateFullscreen;

This new API is missing an availability annotation. It should be WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA).

[Eric Carlson]

(In reply to comment #6)
> Comment on attachment 241686 [details]
> Proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241686&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h:108
> > +@property (nonatomic) BOOL allowsAlternateFullscreen;
> 
> This new API is missing an availability annotation. It should be
> WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA).

Thanks for the reminder. Upon reflection this doesn't need to be public, so I will move it into the private header.

[Eric Carlson]

Committed r176283: https://trac.webkit.org/r176283