Bug 138765 - Implement data detectors and mailto action menus for WebKit1
Summary: Implement data detectors and mailto action menus for WebKit1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-14 18:25 PST by Tim Horton
Modified: 2014-11-15 00:13 PST (History)
6 users (show)

See Also:

Attachments
Patch (13.00 KB, patch)
2014-11-14 18:26 PST, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-11-14 18:25:49 PST 
Implement data detectors and mailto action menus for WebKit1
Comment 1 Tim Horton 2014-11-14 18:26:25 PST 
Created attachment 241653 [details]
Patch
Comment 2 Tim Horton 2014-11-14 18:28:13 PST 
rdar://problem/18877535
Comment 3 WebKit Commit Bot 2014-11-14 18:29:33 PST 
Attachment 241653 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:535:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:536:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:537:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Beth Dakin 2014-11-14 23:49:28 PST 
Comment on attachment 241653 [details]
Patch

YAY
Comment 5 Tim Horton 2014-11-15 00:13:35 PST 
http://trac.webkit.org/changeset/176153