Bug 138718 - Compute the selector specificity as we match simple selectors
Summary: Compute the selector specificity as we match simple selectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-13 16:34 PST by Benjamin Poulain
Modified: 2014-11-14 18:32 PST (History)
3 users (show)

See Also:

Attachments
Patch (20.66 KB, patch)
2014-11-13 16:36 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (663.72 KB, application/zip)
2014-11-13 20:10 PST, Build Bot 		no flags Details
Patch (20.80 KB, patch)
2014-11-13 20:39 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (590.75 KB, application/zip)
2014-11-13 21:48 PST, Build Bot 		no flags Details
Patch (20.80 KB, patch)
2014-11-14 15:59 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-11-13 16:34:01 PST 
Compute the selector specificity as we match simple selectors
Comment 1 Benjamin Poulain 2014-11-13 16:36:17 PST 
Created attachment 241518 [details]
Patch
Comment 2 Chris Dumez 2014-11-13 17:49:04 PST 
Comment on attachment 241518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241518&action=review

> Source/WebCore/css/CSSSelector.cpp:120
> +unsigned CSSSelector::addSpecificity(unsigned a, unsigned b)

plural?

> Source/WebCore/css/SelectorChecker.cpp:1039
> +            unsigned ignoreSpecificity = 0;

"ignoredSpecificity".
Comment 3 Build Bot 2014-11-13 20:10:39 PST 
Comment on attachment 241518 [details]
Patch

Attachment 241518 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6460825778782208

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2014-11-13 20:10:43 PST 
Created attachment 241539 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Benjamin Poulain 2014-11-13 20:39:42 PST 
Created attachment 241546 [details]
Patch
Comment 6 Build Bot 2014-11-13 21:48:01 PST 
Comment on attachment 241546 [details]
Patch

Attachment 241546 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5367891893420032

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2014-11-13 21:48:03 PST 
Created attachment 241554 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Benjamin Poulain 2014-11-14 15:59:07 PST 
Created attachment 241636 [details]
Patch
Comment 9 Benjamin Poulain 2014-11-14 18:32:30 PST 
Comment on attachment 241636 [details]
Patch

Clearing flags on attachment: 241636

Committed r176152: <http://trac.webkit.org/changeset/176152>
Comment 10 Benjamin Poulain 2014-11-14 18:32:33 PST 
All reviewed patches have been landed.  Closing bug.