Bug 138704 – Simple line layout: Move simple line layout RunResolver and LineResolver implementation to SimpleLineLayoutResolver.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

from SimpleLineLayoutResolver.h.

[alan]

Created attachment 241498 [details]
Patch

[Antti Koivisto]

Comment on attachment 241498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241498&action=review

Hope this doesn't make things slower.

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:43
> -    IteratorType begin() const { return m_begin; }
> -    IteratorType end() const { return m_end; }
> +    inline IteratorType begin() const { return m_begin; }
> +    inline IteratorType end() const { return m_end; }

The inline keywords here and elsewhere don't do anything and should not be added.

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:80
> +        inline bool operator==(const Iterator& other) const { ASSERT(&m_resolver == &other.m_resolver); return m_runIndex == other.m_runIndex; }
> +        inline bool operator!=(const Iterator& other) const { return !(*this == other); }
>  
> -        Run operator*() const;
> +        inline Run operator*() const { return Run(*this); }

Multiline function definitions should stay on the bottom of the file. 

I don't generally think anything except trivial accessors should be inlined to declaration.

[Antti Koivisto]

r=me but please keep the function bodies that stay in the header as-is.

[alan]

Created attachment 241509 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 241509 [details]
Patch

Clearing flags on attachment: 241509

Committed r176123: <http://trac.webkit.org/changeset/176123>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.