Bug 138686 – Subclass CachedFont for SVG fonts

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Subclass CachedFont for SVG fongs

[Myles C. Maxfield]

Created attachment 241470 [details]
Patch

[Build Bot]

Comment on attachment 241470 [details]
Patch

Attachment 241470 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5725993381658624

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 241532 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 241470 [details]
Patch

Attachment 241470 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5481747181469696

New failing tests:
svg/custom/acid3-test-77.html

[Build Bot]

Created attachment 241542 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Myles C. Maxfield]

Created attachment 241750 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 241750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241750&action=review

> Source/WebCore/css/CSSFontFaceSource.h:35
> +#if ENABLE(SVG_FONTS)
> +#include "SVGFontElement.h"
> +#include "SVGFontFaceElement.h"
> +#endif

We normally pull #ifdeffed sets of headers to the end of the list.

> Source/WebCore/loader/cache/CachedSVGFont.cpp:102
> +        size_t start = remoteURI.find('#');
> +        if (start != notFound)
> +            fragmentIdentifier = remoteURI.string().substring(start + 1);

What does this do if remoteURI is "foo#"?

> Source/WebCore/loader/cache/CachedSVGFont.h:53
> +    SVGFontElement* m_externalSVGFontElement;

Should this be a RefPtr?

[Myles C. Maxfield]

http://trac.webkit.org/changeset/176264

[WebKit Commit Bot]

Re-opened since this is blocked by bug 138837

[Myles C. Maxfield]

The test failures were caused by flakey bots, not this commit. Re-landed in http://trac.webkit.org/changeset/176276