WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
138487
Move _ignoresNonWheelMouseEvents implementation to WKView(Private)
https://bugs.webkit.org/show_bug.cgi?id=138487
Summary
Move _ignoresNonWheelMouseEvents implementation to WKView(Private)
Conrad Shultz
Reported
2014-11-06 17:29:39 PST
_ignoresNonWheelMouseEvents is declared in WKView(Private) but implemented in WKView, which can cause warnings. The implementation should match the declaration.
Attachments
Patch
(2.03 KB, patch)
2014-11-08 16:03 PST
,
Conrad Shultz
no flags
Details
Formatted Diff
Diff
Patch
(2.03 KB, patch)
2014-11-08 16:35 PST
,
Conrad Shultz
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Conrad Shultz
Comment 1
2014-11-08 16:03:36 PST
Created
attachment 241239
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2014-11-08 16:04:31 PST
<
rdar://problem/18919700
>
mitz
Comment 3
2014-11-08 16:04:59 PST
Comment on
attachment 241239
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=241239&action=review
> Source/WebKit2/ChangeLog:8 > + Relocate some methods that should be been in a category implementation.
Typo: “be been”.
Conrad Shultz
Comment 4
2014-11-08 16:35:27 PST
Created
attachment 241241
[details]
Patch
Conrad Shultz
Comment 5
2014-11-08 16:36:01 PST
(In reply to
comment #3
)
> Comment on
attachment 241239
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=241239&action=review
> > > Source/WebKit2/ChangeLog:8 > > + Relocate some methods that should be been in a category implementation. > > Typo: “be been”.
Whoops; revised version posted (for cq purposes).
WebKit Commit Bot
Comment 6
2014-11-09 02:12:19 PST
Comment on
attachment 241241
[details]
Patch Clearing flags on attachment: 241241 Committed
r175790
: <
http://trac.webkit.org/changeset/175790
>
WebKit Commit Bot
Comment 7
2014-11-09 02:12:24 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug