Bug 138487 - Move _ignoresNonWheelMouseEvents implementation to WKView(Private)
Summary: Move _ignoresNonWheelMouseEvents implementation to WKView(Private)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Conrad Shultz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-06 17:29 PST by Conrad Shultz
Modified: 2014-11-09 02:12 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2014-11-08 16:03 PST, Conrad Shultz 		no flags Details | Formatted Diff | Diff
Patch (2.03 KB, patch)
2014-11-08 16:35 PST, Conrad Shultz 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2014-11-06 17:29:39 PST 
_ignoresNonWheelMouseEvents is declared in WKView(Private) but implemented in WKView, which can cause warnings. The implementation should match the declaration.
Comment 1 Conrad Shultz 2014-11-08 16:03:36 PST 
Created attachment 241239 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2014-11-08 16:04:31 PST 
<rdar://problem/18919700>
Comment 3 mitz 2014-11-08 16:04:59 PST 
Comment on attachment 241239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241239&action=review

> Source/WebKit2/ChangeLog:8
> +        Relocate some methods that should be been in a category implementation.

Typo: “be been”.
Comment 4 Conrad Shultz 2014-11-08 16:35:27 PST 
Created attachment 241241 [details]
Patch
Comment 5 Conrad Shultz 2014-11-08 16:36:01 PST 
(In reply to comment #3)
> Comment on attachment 241239 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241239&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        Relocate some methods that should be been in a category implementation.
> 
> Typo: “be been”.


Whoops; revised version posted (for cq purposes).
Comment 6 WebKit Commit Bot 2014-11-09 02:12:19 PST 
Comment on attachment 241241 [details]
Patch

Clearing flags on attachment: 241241

Committed r175790: <http://trac.webkit.org/changeset/175790>
Comment 7 WebKit Commit Bot 2014-11-09 02:12:24 PST 
All reviewed patches have been landed.  Closing bug.