WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
138466
Add API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
https://bugs.webkit.org/show_bug.cgi?id=138466
Summary
Add API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient cla...
Carlos Garcia Campos
Reported
2014-11-06 07:42:00 PST
Add API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
Attachments
Patch
(42.33 KB, patch)
2014-11-06 07:48 PST
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
Updated patch
(46.14 KB, patch)
2014-11-12 09:19 PST
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
Try to fix mac build
(47.21 KB, patch)
2014-11-12 23:10 PST
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
Rebased patch
(47.35 KB, patch)
2015-01-05 05:30 PST
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
Rebased and updated to use references instead of pointers
(47.36 KB, patch)
2015-01-20 09:25 PST
,
Carlos Garcia Campos
andersca
: review+
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2014-11-06 07:48:18 PST
Created
attachment 241107
[details]
Patch I've removed the deleted files from the pbxproj file, but as usual I need help with the new files.
Anders Carlsson
Comment 2
2014-11-06 08:48:23 PST
Is this just cleanup with no functionality change?
Carlos Garcia Campos
Comment 3
2014-11-06 09:09:30 PST
(In reply to
comment #2
)
> Is this just cleanup with no functionality change?
Yes, I did it to simplify the GTK+ implementation, see
bug #138467
.
Carlos Garcia Campos
Comment 4
2014-11-12 09:19:10 PST
Created
attachment 241428
[details]
Updated patch Now with the (hopefully correct) xcodeproj file changes
Carlos Garcia Campos
Comment 5
2014-11-12 23:10:32 PST
Created
attachment 241474
[details]
Try to fix mac build
Carlos Garcia Campos
Comment 6
2015-01-05 05:30:11 PST
Created
attachment 243973
[details]
Rebased patch
Carlos Garcia Campos
Comment 7
2015-01-20 09:25:57 PST
Created
attachment 244995
[details]
Rebased and updated to use references instead of pointers
Anders Carlsson
Comment 8
2015-01-21 08:51:49 PST
Comment on
attachment 244995
[details]
Rebased and updated to use references instead of pointers View in context:
https://bugs.webkit.org/attachment.cgi?id=244995&action=review
> Source/WebKit2/ChangeLog:1 > +2014-11-12 Carlos Garcia Campos <
carlos@Carloss-Mac.local
>
Please fix your e-mail address.
Carlos Garcia Campos
Comment 9
2015-01-21 23:53:04 PST
Committed
r178889
: <
http://trac.webkit.org/changeset/178889
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug