Bug 138339 - Re-evaluate if a repetitive timer should be throttled upon firing
Summary: Re-evaluate if a repetitive timer should be throttled upon firing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 136197
Blocks: 138292
  Show dependency treegraph
 
Reported: 2014-11-03 17:33 PST by Chris Dumez
Modified: 2014-11-05 10:43 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2014-11-03 17:52 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-03 17:33:46 PST
We should re-evaluate if a repetitive timer should be throttled upon firing in case the plugin observability state has changed:
- It used to be visible but now isn't and thus the timer can be throttled
- It used to play audio but now doesn't and thus the timer can be throttled

We already stop throttling if the plugin becomes observable. However, we don't start throttling if the plugin becomes non-observable.
Comment 1 Chris Dumez 2014-11-03 17:52:23 PST
Created attachment 240891 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-05 10:43:14 PST
Comment on attachment 240891 [details]
Patch

Clearing flags on attachment: 240891

Committed r175627: <http://trac.webkit.org/changeset/175627>
Comment 3 WebKit Commit Bot 2014-11-05 10:43:17 PST
All reviewed patches have been landed.  Closing bug.