Bug 138309 - [EFL] Fix the build if LOG_DISABLED=0 in release mode
Summary: [EFL] Fix the build if LOG_DISABLED=0 in release mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-03 06:14 PST by Tibor Mészáros
Modified: 2014-11-03 10:01 PST (History)
5 users (show)

See Also:

Attachments
Patch (898 bytes, patch)
2014-11-03 06:19 PST, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2014-11-03 06:14:12 PST 
Enabling logging in release mode can be enough to debug an issue.
But now the build is broken with the following error:

../../Source/WebCore/platform/efl/LoggingEfl.cpp: In function 'WTF::String WebCore::logLevelString()':
../../Source/WebCore/platform/efl/LoggingEfl.cpp:40:141: error: 'EINA_LOG_WARN' was not declared in this scope
Comment 1 Tibor Mészáros 2014-11-03 06:19:52 PST 
Created attachment 240846 [details]
Patch

This patch will fix the build error.
Comment 2 Chris Dumez 2014-11-03 09:24:31 PST 
Comment on attachment 240846 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-11-03 10:01:01 PST 
Comment on attachment 240846 [details]
Patch

Clearing flags on attachment: 240846

Committed r175472: <http://trac.webkit.org/changeset/175472>
Comment 4 WebKit Commit Bot 2014-11-03 10:01:06 PST 
All reviewed patches have been landed.  Closing bug.