Bug 138240 - Fix a couple of warnings in JSC reported by clang static analyzer
Summary: Fix a couple of warnings in JSC reported by clang static analyzer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-30 22:50 PDT by Chris Dumez
Modified: 2014-10-31 10:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.13 KB, patch)
2014-10-30 22:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-30 22:50:17 PDT 
Fix a couple of warnings in JSC reported by clang static analyzer, about useless variable assignment / variable scope.
Comment 1 Chris Dumez 2014-10-30 22:53:33 PDT 
Created attachment 240725 [details]
Patch
Comment 2 Chris Dumez 2014-10-30 22:55:38 PDT 
The static analyzer also found https://bugs.webkit.org/show_bug.cgi?id=136869#c26 but I'll let someone else fix that one as I am not sure what was Oliver's intent.
Comment 3 Geoffrey Garen 2014-10-31 09:59:10 PDT 
Comment on attachment 240725 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-10-31 10:37:21 PDT 
Comment on attachment 240725 [details]
Patch

Clearing flags on attachment: 240725

Committed r175411: <http://trac.webkit.org/changeset/175411>
Comment 5 WebKit Commit Bot 2014-10-31 10:37:26 PDT 
All reviewed patches have been landed.  Closing bug.