138237 – Web Inspector: standardize language-specific protocol generator file, class, and method prefixes

RESOLVED FIXED 138237

Web Inspector: standardize language-specific protocol generator file, class, and method prefixes

https://bugs.webkit.org/show_bug.cgi?id=138237

Summary Web Inspector: standardize language-specific protocol generator file, class, ...

Brian Burg

Reported 2014-10-30 19:53:20 PDT

ObjC and objc for Objective C, Cpp and cpp for C++. JS for JavaScript (duh)

Attachments
Patch (452.37 KB, patch) 2014-11-01 19:56 PDT, Brian Burg	joepeck: review+	Details Formatted Diff Diff
Patch (458.50 KB, patch) 2014-11-18 14:55 PST, Brian Burg	no flags	Details Formatted Diff Diff
Final patch for EWS (444.04 KB, patch) 2014-11-18 16:36 PST, Brian Burg	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-10-30 19:53:31 PDT

<rdar://problem/18833453>

Brian Burg

Comment 2 2014-11-01 19:56:41 PDT

Created attachment 240802 [details] Patch

WebKit Commit Bot

Comment 3 2014-11-01 19:58:23 PDT

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

WebKit Commit Bot

Comment 4 2014-11-01 19:58:37 PDT

Attachment 240802 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:77: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:103: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:66: [CppFrontendDispatcherHeaderGenerator.generate_output] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:84: [CppFrontendDispatcherHeaderGenerator._generate_anonymous_enum_for_parameter] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'encoding_for_enum_value' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:90: [CppFrontendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:106: [CppFrontendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:61: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:62: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:64: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:66: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py:30: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:50: [ObjCBackendDispatcherHeaderGenerator.domains_to_generate] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:66: [ObjCBackendDispatcherHeaderGenerator.generate_output] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:96: [ObjCBackendDispatcherHeaderGenerator._generate_objc_handler_declarations_for_domain] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:58: [CppAlternateBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:60: [CppAlternateBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:79: [CppAlternateBackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:48: [ObjCFrontendDispatcherImplementationGenerator.domains_to_generate] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:64: [ObjCFrontendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:55: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:56: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:58: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:60: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:62: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:76: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:87: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:95: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:55: [JSBackendCommandsGenerator.generate_output] Instance of 'JSBackendCommandsGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:54: [ObjCConversionHelpersGenerator.domains_to_generate] Instance of 'ObjCConversionHelpersGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:67: [ObjCConversionHelpersGenerator.generate_output] Instance of 'ObjCConversionHelpersGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:87: too many blank lines (3) [pep8/E303] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:62: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:63: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:64: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:65: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:73: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:105: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:113: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:149: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:195: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:69: [CppBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:86: [CppBackendDispatcherHeaderGenerator._generate_alternate_handler_forward_declarations_for_domains] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:92: [CppBackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:108: [CppBackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:120: [CppBackendDispatcherHeaderGenerator._generate_anonymous_enum_for_parameter] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'encoding_for_enum_value' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:167: [CppBackendDispatcherHeaderGenerator._generate_async_handler_declaration_for_command] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:183: [CppBackendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:198: [CppBackendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:55: whitespace before ']' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:274: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:296: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:49: [CppProtocolTypesHeaderGenerator.generate_output] Instance of 'CppProtocolTypesHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:50: [CppProtocolTypesHeaderGenerator.generate_output] Instance of 'CppProtocolTypesHeaderGenerator' has no 'calculate_types_requiring_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:58: [CppProtocolTypesHeaderGenerator.generate_output] Instance of 'CppProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:72: [CppProtocolTypesHeaderGenerator.generate_output] Instance of 'CppProtocolTypesHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:115: [CppProtocolTypesHeaderGenerator._generate_forward_declarations] Instance of 'CppProtocolTypesHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:154: [CppProtocolTypesHeaderGenerator._generate_typedefs_for_domain] Instance of 'CppProtocolTypesHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:173: [CppProtocolTypesHeaderGenerator._generate_builders_for_domain] Instance of 'CppProtocolTypesHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:218: [CppProtocolTypesHeaderGenerator._generate_class_for_object_declaration] Instance of 'CppProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:246: [CppProtocolTypesHeaderGenerator._generate_struct_for_enum_type] Instance of 'CppProtocolTypesHeaderGenerator' has no 'encoding_for_enum_value' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:314: [CppProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits] Instance of 'CppProtocolTypesHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:315: [CppProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits.<lambda>] Instance of 'CppProtocolTypesHeaderGenerator' has no 'type_needs_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:327: [CppProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits] Instance of 'CppProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:42: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:48: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:50: [ObjCConfigurationImplementationGenerator.domains_to_generate] Instance of 'ObjCConfigurationImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:67: [ObjCConfigurationImplementationGenerator.generate_output] Instance of 'ObjCConfigurationImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:98: [ObjCConfigurationImplementationGenerator._generate_handler_implementation_for_command] Instance of 'ObjCConfigurationImplementationGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:112: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:131: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:147: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/g enerate_cpp_protocol_types_implementation.py:48: [CppProtocolTypesImplementationGenerator.generate_output] Instance of 'CppProtocolTypesImplementationGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:49: [CppProtocolTypesImplementationGenerator.generate_output] Instance of 'CppProtocolTypesImplementationGenerator' has no 'calculate_types_requiring_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:59: [CppProtocolTypesImplementationGenerator.generate_output] Instance of 'CppProtocolTypesImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:76: [CppProtocolTypesImplementationGenerator._generate_enum_mapping] Instance of 'CppProtocolTypesImplementationGenerator' has no 'assigned_enum_values' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:86: [CppProtocolTypesImplementationGenerator._generate_open_field_names] Instance of 'CppProtocolTypesImplementationGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:96: [CppProtocolTypesImplementationGenerator._generate_builders_for_domain.<lambda>] Instance of 'CppProtocolTypesImplementationGenerator' has no 'type_needs_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:105: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:59: [CppFrontendDispatcherImplementationGenerator.generate_output] Instance of 'CppFrontendDispatcherImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:72: [CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementations_for_domain] Instance of 'CppFrontendDispatcherImplementationGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:79: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:114: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:124: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:130: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:164: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:185: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:201: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:68: [CppBackendDispatcherImplementationGenerator.generate_output] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:82: [CppBackendDispatcherImplementationGenerator._generate_handler_class_destructor_for_domain] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:102: [CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementations_for_domain] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py:30: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:54: [ObjCProtocolTypesImplementationGenerator.domains_to_generate] Instance of 'ObjCProtocolTypesImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:71: [ObjCProtocolTypesImplementationGenerator.generate_output] Instance of 'ObjCProtocolTypesImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_internal_header.py:58: [ObjCInternalHeaderGenerator.generate_output] Instance of 'ObjCInternalHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_internal_header.py:59: [ObjCInternalHeaderGenerator.generate_output] Instance of 'ObjCInternalHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_internal_header.py:62: [ObjCInternalHeaderGenerator.generate_output] Instance of 'ObjCInternalHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:136: [generate_from_specification] Undefined variable 'JSBackendCommandsGenerator' [pylint/E0602] [5] Total errors found: 97 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 5 2014-11-13 12:18:01 PST

Comment on attachment 240802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240802&action=review r=me on the renames. > Source/JavaScriptCore/ChangeLog:24 > + * inspector/scripts/codegen/cpp_generator.py: Copied from Source/JavaScriptCore/inspector/scripts/codegen/generator.py. > + (CppGenerator): > + (CppGenerator.cpp_getter_method_for_type): > + (CppGenerator.cpp_setter_method_for_type): > + (CppGenerator.cpp_protocol_type_for_type): > + (CppGenerator.cpp_protocol_type_for_type_member): > + (CppGenerator.cpp_type_for_unchecked_formal_in_parameter): You should eliminate these method lines, and include just the files. The rest is unnecessary.

Brian Burg

Comment 6 2014-11-18 14:55:03 PST

Created attachment 241816 [details] Patch

Brian Burg

Comment 7 2014-11-18 16:36:49 PST

Created attachment 241832 [details] Final patch for EWS

WebKit Commit Bot

Comment 8 2014-11-18 16:46:19 PST

Attachment 241832 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:77: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:103: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:66: [CppFrontendDispatcherHeaderGenerator.generate_output] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:84: [CppFrontendDispatcherHeaderGenerator._generate_anonymous_enum_for_parameter] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'encoding_for_enum_value' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:90: [CppFrontendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:106: [CppFrontendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppFrontendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:61: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:62: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:64: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:66: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py:30: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:50: [ObjCBackendDispatcherHeaderGenerator.domains_to_generate] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:66: [ObjCBackendDispatcherHeaderGenerator.generate_output] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:96: [ObjCBackendDispatcherHeaderGenerator._generate_objc_handler_declarations_for_domain] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:58: [CppAlternateBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:60: [CppAlternateBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:79: [CppAlternateBackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain] Instance of 'CppAlternateBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:48: [ObjCFrontendDispatcherImplementationGenerator.domains_to_generate] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:64: [ObjCFrontendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:55: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:56: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:58: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:60: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:62: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:76: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:87: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:99: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:106: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:111: expected 1 blank line, found 0 [pep8/E301] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_js_backend_commands.py:55: [JSBackendCommandsGenerator.generate_output] Instance of 'JSBackendCommandsGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:54: [ObjCConversionHelpersGenerator.domains_to_generate] Instance of 'ObjCConversionHelpersGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:67: [ObjCConversionHelpersGenerator.generate_output] Instance of 'ObjCConversionHelpersGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:87: too many blank lines (3) [pep8/E303] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:62: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:63: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:64: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:65: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:73: [ObjCHeaderGenerator.generate_output] Instance of 'ObjCHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:105: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:113: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:149: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:195: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:69: [CppBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:86: [CppBackendDispatcherHeaderGenerator._generate_alternate_handler_forward_declarations_for_domains] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:92: [CppBackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:108: [CppBackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:120: [CppBackendDispatcherHeaderGenerator._generate_anonymous_enum_for_parameter] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'encoding_for_enum_value' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:167: [CppBackendDispatcherHeaderGenerator._generate_async_handler_declaration_for_command] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:183: [CppBackendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:198: [CppBackendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:55: whitespace before ']' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:274: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:296: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:49: [CppProtocolTypesHeaderGenerator.generate_output] Instance of 'CppProtocolTypesHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:50: [CppProtocolTypesHeaderGenerator.generate_output] Instance of 'CppProtocolTypesHeaderGenerator' has no 'calculate_types_requiring_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:58: [CppProtocolTypesHeaderGenerator.generate_output] Instance of 'CppProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:72: [CppProtocolTypesHeaderGenerator.generate_output] Instance of 'CppProtocolTypesHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:115: [CppProtocolTypesHeaderGenerator._generate_forward_declarations] Instance of 'CppProtocolTypesHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:154: [CppProtocolTypesHeaderGenerator._generate_typedefs_for_domain] Instance of 'CppProtocolTypesHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:173: [CppProtocolTypesHeaderGenerator._generate_builders_for_domain] Instance of 'CppProtocolTypesHeaderGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:218: [CppProtocolTypesHeaderGenerator._generate_class_for_object_declaration] Instance of 'CppProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:246: [CppProtocolTypesHeaderGenerator._generate_struct_for_enum_type] Instance of 'CppProtocolTypesHeaderGenerator' has no 'encoding_for_enum_value' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:314: [CppProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits] Instance of 'CppProtocolTypesHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:315: [CppProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits.<lambda>] Instance of 'CppProtocolTypesHeaderGenerator' has no 'type_needs_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:327: [CppProtocolTypesHeaderGenerator._generate_forward_declarations_for_binding_traits] Instance of 'CppProtocolTypesHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:42: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:48: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:50: [ObjCConfigurationImplementationGenerator.domains_to_generate] Instance of 'ObjCConfigurationImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:67: [ObjCConfigurationImplementationGenerator.generate_output] Instance of 'ObjCConfigurationImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:98: [ObjCConfigurationImplementationGenerator._generate_handler_implementation_for_command] Instance of 'ObjCConfigurationImplementationGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:112: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protoco l_types_implementation.py:131: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:147: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:48: [CppProtocolTypesImplementationGenerator.generate_output] Instance of 'CppProtocolTypesImplementationGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:49: [CppProtocolTypesImplementationGenerator.generate_output] Instance of 'CppProtocolTypesImplementationGenerator' has no 'calculate_types_requiring_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:59: [CppProtocolTypesImplementationGenerator.generate_output] Instance of 'CppProtocolTypesImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:76: [CppProtocolTypesImplementationGenerator._generate_enum_mapping] Instance of 'CppProtocolTypesImplementationGenerator' has no 'assigned_enum_values' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:86: [CppProtocolTypesImplementationGenerator._generate_open_field_names] Instance of 'CppProtocolTypesImplementationGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:96: [CppProtocolTypesImplementationGenerator._generate_builders_for_domain.<lambda>] Instance of 'CppProtocolTypesImplementationGenerator' has no 'type_needs_shape_assertions' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:105: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:59: [CppFrontendDispatcherImplementationGenerator.generate_output] Instance of 'CppFrontendDispatcherImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:72: [CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementations_for_domain] Instance of 'CppFrontendDispatcherImplementationGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:79: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:114: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:124: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:130: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:164: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:185: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:201: whitespace before '}' [pep8/E202] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:68: [CppBackendDispatcherImplementationGenerator.generate_output] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:82: [CppBackendDispatcherImplementationGenerator._generate_handler_class_destructor_for_domain] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:102: [CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementations_for_domain] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'wrap_with_guard_for_domain' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py:30: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:54: [ObjCProtocolTypesImplementationGenerator.domains_to_generate] Instance of 'ObjCProtocolTypesImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:71: [ObjCProtocolTypesImplementationGenerator.generate_output] Instance of 'ObjCProtocolTypesImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_internal_header.py:58: [ObjCInternalHeaderGenerator.generate_output] Instance of 'ObjCInternalHeaderGenerator' has no 'domains_to_generate' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_internal_header.py:59: [ObjCInternalHeaderGenerator.generate_output] Instance of 'ObjCInternalHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_internal_header.py:62: [ObjCInternalHeaderGenerator.generate_output] Instance of 'ObjCInternalHeaderGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:136: [generate_from_specification] Undefined variable 'JSBackendCommandsGenerator' [pylint/E0602] [5] Total errors found: 99 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brian Burg

Comment 9 2014-11-19 11:16:12 PST

Committed r176329: <http://trac.webkit.org/changeset/176329>

Joseph Pecoraro

Comment 10 2014-11-19 13:41:52 PST

Follow up fixes: http://trac.webkit.org/changeset/176335

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component Web Inspector

Assignee

Brian Burg

Reported

2014-10-30 19:53 PDT

Modified

2014-11-19 13:41 PST History

CC List

9 users Show

URL

Keywords InRadar

Depends on

Blocks