WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
138085
Move some RenderObject member functions to RenderElement.
https://bugs.webkit.org/show_bug.cgi?id=138085
Summary
Move some RenderObject member functions to RenderElement.
Andreas Kling
Reported
2014-10-26 13:43:15 PDT
Minor cleanup patch coming.
Attachments
Patch
(12.55 KB, patch)
2014-10-26 13:43 PDT
,
Andreas Kling
cdumez
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2014-10-26 13:43:40 PDT
Created
attachment 240468
[details]
Patch
WebKit Commit Bot
Comment 2
2014-10-26 13:45:27 PDT
Attachment 240468
[details]
did not pass style-queue: ERROR: Source/WebCore/rendering/RenderElement.cpp:903: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/rendering/RenderElement.h:221: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/ChangeLog:16: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3
2014-10-26 14:57:23 PDT
Comment on
attachment 240468
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=240468&action=review
r=me
> Source/WebCore/ChangeLog:16 > + No new tests (OOPS!).
OOPS
Andreas Kling
Comment 4
2014-10-26 15:24:56 PDT
Committed
r175211
: <
http://trac.webkit.org/changeset/175211
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug