Bug 138037 - Make ScriptWrappable's destructor protected instead of public
Summary: Make ScriptWrappable's destructor protected instead of public
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 21:11 PDT by Chris Dumez
Modified: 2014-10-24 11:13 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2014-10-23 21:27 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-23 21:11:45 PDT
Make ScriptWrappable's destructor protected instead of public as it is not virtual and this class is subclassed a lot.
Comment 1 Chris Dumez 2014-10-23 21:27:51 PDT
Created attachment 240389 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-24 11:13:32 PDT
Comment on attachment 240389 [details]
Patch

Clearing flags on attachment: 240389

Committed r175168: <http://trac.webkit.org/changeset/175168>
Comment 3 WebKit Commit Bot 2014-10-24 11:13:36 PDT
All reviewed patches have been landed.  Closing bug.