Bug 137972 - [GTK] Do not build WidgetBackingStoreGtkX11 when not used
Summary: [GTK] Do not build WidgetBackingStoreGtkX11 when not used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 137488
  Show dependency treegraph
 
Reported: 2014-10-22 11:21 PDT by Milan Crha
Modified: 2014-10-22 23:41 PDT (History)
2 users (show)

See Also:


Attachments
proposed wk patch (1.91 KB, patch)
2014-10-22 11:23 PDT, Milan Crha
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Crha 2014-10-22 11:21:53 PDT
The WidgetBackingStoreGtkX11 is used only under certain conditions, but it is compiled unconditionally, which can cause a build break eventually.
Comment 1 Milan Crha 2014-10-22 11:23:34 PDT
Created attachment 240282 [details]
proposed wk patch
Comment 2 Carlos Garcia Campos 2014-10-22 23:03:29 PDT
Comment on attachment 240282 [details]
proposed wk patch

Thanks!
Comment 3 WebKit Commit Bot 2014-10-22 23:41:49 PDT
Comment on attachment 240282 [details]
proposed wk patch

Clearing flags on attachment: 240282

Committed r175087: <http://trac.webkit.org/changeset/175087>
Comment 4 WebKit Commit Bot 2014-10-22 23:41:54 PDT
All reviewed patches have been landed.  Closing bug.