Bug 137694 - [EFL] Unskip now passing http tests
Summary: [EFL] Unskip now passing http tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-14 07:15 PDT by Tibor Mészáros
Modified: 2014-11-11 08:29 PST (History)
5 users (show)

See Also:

Attachments
WIP patch (3.78 KB, patch)
2014-10-14 07:20 PDT, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
Patch (5.49 KB, patch)
2014-11-10 08:41 PST, Tibor Mészáros 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2014-10-14 07:15:40 PDT 
We should unskip now passing http tests on EFL.
Comment 1 Tibor Mészáros 2014-10-14 07:20:49 PDT 
Created attachment 239799 [details]
WIP patch

A last test is needed, because of the flakey tests.
Comment 2 Tibor Mészáros 2014-11-10 08:41:56 PST 
Created attachment 241292 [details]
Patch

This patch will unskip 1552 test, which doesn't come to crash.
Comment 3 Csaba Osztrogonác 2014-11-11 06:54:48 PST 
Comment on attachment 241292 [details]
Patch

LGTM, increasing test coverage is always welcome. ;)

But the EFL bot is offline now, we should land it after the bot came back.
Comment 4 Gyuyoung Kim 2014-11-11 07:52:00 PST 
Comment on attachment 241292 [details]
Patch

cq=me. Sorry for lack of EFL bot for a while.
Comment 5 WebKit Commit Bot 2014-11-11 08:29:25 PST 
Comment on attachment 241292 [details]
Patch

Clearing flags on attachment: 241292

Committed r175931: <http://trac.webkit.org/changeset/175931>
Comment 6 WebKit Commit Bot 2014-11-11 08:29:28 PST 
All reviewed patches have been landed.  Closing bug.